search

RetroPie / RetroPie-Setup

Shell script to set up a Raspberry Pi/Odroid/PC with RetroArch emulator and various cores
Other
9.99k stars 1.38k forks source link

dxx-rebirth game data #3922

Closed s1eve-mcdichae1 closed 4 weeks ago

s1eve-mcdichae1 commented 1 month ago

Don't download D2 shareware data if registered version files exist.

Ignore case - don't download D1/D2 shareware whether user-provided data files in ALL CAPS (DOS) or lowercase (Steam).

Shareware and add-on files no longer available from dxx-rebirth.com - switch to self-hosted files at $__archive_url (I don't know how to actually put them there, though. Someone else will have to do that part, or show me how.)

joolswills commented 1 month ago

I have some dxx rebirth changes in progress including the game data locations. I've already uploaded them to our server I think. I'll try and finish it this week.

joolswills commented 1 month ago

Please see #3923

I am happy to include your changes minus the shareware data part. I can cherry-pick your commits into my branch if you like or you can open a new PR with them.

One thing I would change in your code is to not use 2 find calls and instead do

[[ -z "$(find "$dest_d2" -maxdepth 1 \( -iname D2DEMO.HOG -o -iname DESCENT2.HOG \))" ]]

Thanks for the PR :-)

s1eve-mcdichae1 commented 1 month ago

I can cherry-pick your commits into my branch if you like or you can open a new PR with them.

So I would open a pull against your branch, then, you mean?

joolswills commented 4 weeks ago

Sorry I meant to do a new PR with just the game data detection changes. However I have merged my changes now and have rebased your branch so it just includes your changes, so I will merge. Thank you.