search

RetroPie / es-theme-carbon

This repository contains the EmulationStation theme "Carbon"
24 stars 108 forks source link

added default theme in support of collections feature #32

Closed jrassa closed 7 years ago

jrassa commented 7 years ago

Uses the new theme variables features to provide a default theme that will be used when no system specific theme exists. This will support the new collections feature (favorites, recent, all games).

The default theme must be the root theme.xml file. Previous version of this file was not being used and only existed as an example.

This change should not effect existing users who have not updated EmulationStation. Changes only effect the default theme, which will not be loaded for those users.

pjft commented 7 years ago

Thank you - this works surprisingly well!

My only comment is that "Favorites" when selected gets shortened to "FAVORI..." on the carousel. Maybe if the font-size is smaller that's sorted, though I don't know if that's something we can change.

A separate question: is there a way to detect that a theme has a default theme defined in ES via code?

Thanks!

joolswills commented 7 years ago

Thanks.

jrassa commented 7 years ago

@pjft setting the font-size for the logo text isn't currently supported. I have some other changes that I have been working on for the carousel so I will try to include it with them.

The default theme is implemented by having a theme.xml file in the root of the theme directory. You should be able to check for the existence of the that file. However, there are a couple of themes where that file already exists. I have most of the themes available from RetroPie-Setup on my dev box so I checked them. carbon and minilumi use it as an example and would cause a false positive. crt, crt-tft and nbba use it as their base theme file, that the system themes import. This is actually beneficial, since they work as a default theme.