Closed Dark-Show closed 7 years ago
Not sure how you are doing your PR, but you are including merge commits in them. I will squash it, but in the future please rebase / squash changes (and make sure things compile) :)
Yeah I'm still learning GitHub I'll Google how to rebase. Also my bad on the compile error, I uploaded the wrong file from my changes. It's fixed now. I feel like such a beginner. Thanks for the help though!
On Nov 8, 2016 9:55 PM, "Jools Wills" notifications@github.com wrote:
Not sure how you are doing your PR, but you are including merge commits in them. I will squash it, but please rebase / squash changes (and make sure things compile) :)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RetroPie/sixad/pull/12#issuecomment-259315674, or mute the thread https://github.com/notifications/unsubscribe-auth/AJPWNPmbcJ7JCN420Z4KfpNFDIIBqINaks5q8SgigaJpZM4KtHPk .
np. thanks for the fix.
Fix a typo leading to compile errors.