RetroShare / RSNewWebUI

30 stars 20 forks source link

Add editor config and update additional lint rules #29

Closed rottencandy closed 3 years ago

rottencandy commented 3 years ago

Everyone uses different editors/IDEs which have their own defaults. This creates lots of unimportant changes and inconsistency in commits.

Having default formats specified would make it easier to maintain standard stuff like indentations and quotes and a linter will also catch commonly occurring syntax bugs.

rottencandy commented 3 years ago

@zeners @Kumaravinash9 I've added some editor defaults here, if you like extra options or more settings, we can add them in the config here.

Kumaravinash9 commented 3 years ago

@rottencandy, It could be much better if we add pipeline testing to check if the coding is formatted or not.

rottencandy commented 3 years ago

@rottencandy, It could be much better if we add pipeline testing to check if the coding is formatted or not.

@csoler would it be a good idea to add a GitHub action that runs a linter on every PR?

Kumaravinash9 commented 3 years ago

@rottencandy, we should also add a .prettierignore file for the folder make-src. So, it will not create any conflicts whenever we will run prettier.

rottencandy commented 3 years ago

Merging the PR, we can run eslint locally for now. And editorconfig should handle common syntax & indentation for all supported editors.