search

RetroShare / RSNewWebUI

30 stars 20 forks source link

UI improvement && logic code for people Webpage #33

Closed Kumaravinash9 closed 3 years ago

Kumaravinash9 commented 3 years ago

UI (ownIdentity)

UI

UI (All Contacts)

UI

Kumaravinash9 commented 3 years ago

@rottencandy, please review this PR.

changes I committed :

rottencandy commented 3 years ago

@Kumaravinash9 sorry I did not notice this earlier, there was already a PR #32 to fix lint errors for the files, so might not be needed again. Perhaps you could rebase this, it should be very straightforward since the changes are the same.

Kumaravinash9 commented 3 years ago

@Kumaravinash9 sorry I did not notice this earlier, there was already a PR #32 to fix lint errors for the files, so might not be needed again. Perhaps you could rebase this, it should be very straightforward since the changes are the same.

@rottencandy. Actually, I did not notice PR #32. Now, I resolved the conflicts as well as correct some files that were not working after merging PR #32. Please review this PR. Thanks

Kumaravinash9 commented 3 years ago

@rottencandy, i have updated the changes that are mentioned above. Please review it.

defnax commented 3 years ago

Hi, maybe you can make a new grid view too? where we can switch the views, its planed by phenom he will finish grid view (people v2 Qt ui) for rs 0.6.7 where we can switch the View in List or Grid (Thumbnail)

View the contacts as Thumbnail View ( later ideas is something sort by Activity, Posts, Votes ) image

Kumaravinash9 commented 3 years ago

Hi, maybe you can make a new grid view too? where we can switch the views, its planed by phenom he will finish grid view (people v2 Qt ui) for rs 0.6.7 where we can switch the View in List or Grid (Thumbnail)

View the contacts as Thumbnail View ( later ideas is something sort by Activity, Posts, Votes ) image

Hello @defnax. we will add grid view once it will be added in Rs 0.6.7

defnax commented 3 years ago

I mean only when you are on the way with coding on the new People display, then its easier add the thumb view too for People

Kumaravinash9 commented 3 years ago

So I tried the changes, they work really well for the most part. But I have around 1000 ids in the people section, and everytime I switch to it, there are a thousand requests sent all at once, which freezes the tab page for several seconds and cpu usage spikes up. I think this will not scale well for lots of identities.

We can certainly move ahead with this PR for now, but in the future we might have to look into reducing the load, for example using lazy loading or pagination.

pagination will be a great idea. In future,We will also require pagination in the mails tabs too.

Kumaravinash9 commented 3 years ago

I mean only when you are on the way with coding on the new People display, then its easier add the thumb view too for People

Sorry for the late reply @defnax. Actually, getdetails JSON request does not provide the profile pic URL for all the identity. Once, i solved this issue then i will add the grid view for the people's tab .