RetroShare / RSNewWebUI

30 stars 20 forks source link

Forums tab 3 #57

Closed Sukhamjot-Singh closed 2 years ago

Sukhamjot-Singh commented 2 years ago

Okay, so I tried calling markRead with an object which has groupId as key and msgID as value and good news is it did not crash. image

BUT, its always returning false :(

Can you confirm if it is mGroupId, mMsgId. This is what I am passing. {"messageId":{"3e321965a3beb9cf4da43a29a2ef0f89":"28189c5c0402c29842a87e96804e1ff28363f197"},"read":false}

@csoler @G10h4ck

Sukhamjot-Singh commented 2 years ago

Okay, so I tried calling markRead with an object which has groupId as key and msgID as value and good news is it did not crash. image

BUT, its always returning false :(

Can you confirm if it is mGroupId, mMsgId. This is what I am passing. {"messageId":{"3e321965a3beb9cf4da43a29a2ef0f89":"28189c5c0402c29842a87e96804e1ff28363f197"},"read":false}

@csoler @G10h4ck

  1. Can anyone also point me towards the API for getting the current Logged in ID.(The identity we are currently logged in by.) cc: @csoler @G10h4ck
csoler commented 2 years ago

So did you manage to do it eventually? I am not sure how to interpret your last commit

Sukhamjot-Singh commented 2 years ago

So did you manage to do it eventually? I am not sure how to interpret your last commit

Yes, G104hck suggested to use {first: , second:}, it worked perfectly

Sukhamjot-Singh commented 2 years ago

I am not sure but I can't seem to get rsPeers/getOwnIdor rsPeers/getGPGOwnId get working. Maybe something on my side but can you check @csoler ?

csoler commented 2 years ago

I'm 100% sure they work (I mean the C++ methods). But you need to have started the core of course (meaning have logged in) for them to reply with a correct answer.

Sukhamjot-Singh commented 2 years ago

image

What exactly are these messages? This is a screenshot of a thread in Forum.

csoler commented 2 years ago

image

What exactly are these messages? This is a screenshot of a thread in Forum.

That means the message is missing because none of your friends have it. That happens e.g. when the writer of the message has been banned by too many people in the close network which prevented RS to find a route to send the message to your own node.

defnax commented 2 years ago

sorry i was away to test your changes...better comments view will done too? like how on youtube? i saw last you not continoued on it, needs for channel and board commenting

defnax commented 2 years ago

this needs to be merged again to much changes :)

defnax commented 2 years ago

hi you has not added yet this: image but i dont know on boards i get a error output, im not sure how you ignore the circleType value

image

but the test boards is created and visible on the qt gui.

Sukhamjot-Singh commented 2 years ago

hi you has not added yet this: image but i dont know on boards i get a error output, im not sure how you ignore the circleType value

image

but the test boards is created and visible on the qt gui.

This is because in the channels API, the circle type is optional

image

In rsposted API, the circle type and id is required. I will add this feature soon.

csoler commented 2 years ago

it's probably time to merge this in?

Sukhamjot-Singh commented 2 years ago

it's probably time to merge this in?

Yes, it is stable to merge.

Sukhamjot-Singh commented 2 years ago

image

I can't seem to get this working. Original code from @rottencandy looks like this

image

Maybe it is something to do with the callback as I think the syntax is right. @csoler Can you help @rottencandy ?

defnax commented 2 years ago

why not merge? better for testing when its merged, you continoue again :)

defnax commented 2 years ago

@Sukhamjot-Singh remove the draft from the PR :)

defnax commented 2 years ago

Hi the creator window its on my screen on bottom and small window image

can you center it and make it bigger? at the moment to much on the bottom, the last parts on creator window not visible on my notebook.

Sukhamjot-Singh commented 2 years ago

Hi the creator window its on my screen on bottom and small window image

can you center it and make it bigger? at the moment to much on the bottom, the last parts on creator window not visible on my notebook.

Oh Okay I will look into it.

defnax commented 2 years ago

your latest update: image

defnax commented 2 years ago

@csoler please merg this

csoler commented 2 years ago

@rottencandy: are we good to merge?

rottencandy commented 2 years ago

Yes, I think we can merge this.