RetroShare / RSNewWebUI

30 stars 20 forks source link

Attachment section for Mail view #72

Closed zelfroster closed 1 year ago

zelfroster commented 1 year ago

Created an attachment section to view and download files sent as attachments with the mail. 1681809237_Apr18_14:43:57

zelfroster commented 1 year ago

With the last commit, I have created two tabs as discussed with @defnax

Please suggest any changes or improvements :)

defnax commented 1 year ago
  • second tab to view all the attachments as a list of files. 1681903934_Apr19_17:02:14

Please suggest any changes or improvements :)

ui would add column names,Filename, i miss Date, From and for download button i would use with text Download

zelfroster commented 1 year ago

ui would add column names,Filename, i miss Date, From and for download button i would use with text Download

image

Sure, will try to implement it 👍🏼

defnax commented 1 year ago

hi i forget, the size column

zelfroster commented 1 year ago

hi i forget, the size column

No worries, I was going to do it as well.

zelfroster commented 1 year ago

Done @defnax 👍🏼, please check it when you are free. 1682002706_Apr20_20:28:26 1682002717_Apr20_20:28:37

defnax commented 1 year ago

it looks nice for me maybe need review by < @rottencandy @csoler

zelfroster commented 1 year ago

I have created one more little feature @csoler .

Should I push it into this PR itself?

ss

csoler commented 1 year ago

If it's relevant to the rest of the PR yes. Sorry for the delay. I'm waiting for rottencandy to take a quick look at the code. The overall graphical design is really cool I have to say.

zelfroster commented 1 year ago

If it's relevant to the rest of the PR yes. Sorry for the delay. I'm waiting for rottencandy to take a quick look at the code. The overall graphical design is really cool I have to say.

Thanks for the appreciation, and The PR is very little addition, so I was thinking that I would just ship it with this PR itself so, Both would get reviewed at once eliminating the wait time and keeping the workflow smooth. I will be working on more things, to be honest, just waiting for it to get reviewed is indeed boring. But I don't mind as taking out time from real work to work on open source projects can be hectic sometimes, so no worries : )

rottencandy commented 1 year ago

Sorry for the delay, looking at it right now

zelfroster commented 1 year ago

Currently looks like this. 1682516132_Apr26_19:05:32

defnax commented 1 year ago

I have created one more little feature @csoler .

Should I push it into this PR itself?

ss [ ![ss]

seems nice that was needed to have more space, when want hide the navbar text :)