RetroShare / RSNewWebUI

30 stars 20 forks source link

feat: implement file search using js proxy #74

Closed zelfroster closed 1 year ago

zelfroster commented 1 year ago

Closes #73 Implemented File Search, which was pending from a long time.

Search results are shown in individual tabs for each search initiated, which is something like this. file_search

This is not perfect enough, but usable. Need to do a lot of formatting and making its functionality better. This PR needs a lot of improvement, please suggest anything which can make it better.

csoler commented 1 year ago

When I click on "submit" it takes me back to login screen. Anyone else experiencing the same problem?

zelfroster commented 1 year ago

When I click on "submit" it takes me back to login screen. Anyone else experiencing the same problem?

I have cloned it from this branch and ran qmake again, and it works. Clone this specific branch and then build it again.

git clone -b implement-file-search https://github.com/zelfroster/RSNewWebUI.git

It should work 😅

csoler commented 1 year ago

I'm recompiling libretroshare. Missing recompilation may be the source of the problem.

zelfroster commented 1 year ago

I'm recompiling libretroshare. Missing recompilation may be the source of the problem.

Ohh, yeah, when I started developing this feature for the first time after you fixed libretroshare, It was also the same.

csoler commented 1 year ago

it seems to work. I indeed made a mistake compiling. Possible improvements are: adding "download" buttons on the right side of each file (or anything that would allow to start a file transfer), file size and possibly hash. The information is all available in the search result.

zelfroster commented 1 year ago

it seems to work. I indeed made a mistake compiling. Possible improvements are: adding "download" buttons on the right side of each file (or anything that would allow to start a file transfer), file size and possibly hash. The information is all available in the search result.

Ohh, that's great. I was kinda scared. Sure, will do it today itself, will make a table layout for it.

zelfroster commented 1 year ago

Made Layout for table and removed some unnecessary logs from console.

Currently, it looks like this 1684864471_May23_23:24:31

zelfroster commented 1 year ago

Fixed it so that search keyword page is show and results start to show as soon as they are received. file_search_fixed

zelfroster commented 1 year ago

Now the latest searched keyword will be at the top and its results will be shown.