search

RetroShare / RSNewWebUI

30 stars 20 forks source link

Config appearance #79

Closed zelfroster closed 1 year ago

zelfroster commented 1 year ago

Added feature to set font-size persistently in browser using localStorage.

Now, user can set a font-size according to their screen sizes. Also, fixed some UI issues while implementing this feature. image

rottencandy commented 1 year ago

Does this PR include commits from other PRs also?

rottencandy commented 1 year ago

Is there a real need for this feature? Won't users simply use the font size setting in their browsers?

zelfroster commented 1 year ago

Is there a real need for this feature? Won't users simply use the font size setting in their browsers?

Yeah, but I thought since sometimes on smaller screens the UI becomes large to view everything perfectly. I know they can control the zoom level with Ctrl++ Ctrl+- to adjust that. But I thought maybe giving them an option to set it themselves would be a good option.

rottencandy commented 1 year ago

We can have this but I was pointing that all browsers also support setting custom font sizes & types if users like. That's why features like this are not commonly seen in web apps.

screenshot-1688366702

rottencandy commented 1 year ago

Like in this PR you have 5 size options, what if users want sizes beyond that, a setting like this is best handled by the browser itself in my opinion

zelfroster commented 1 year ago

Like in this PR you have 5 size options, what if users want sizes beyond that, a setting like this is best handled by the browser itself in my opinion

Ahh, got it. So, I guess I can close this PR now. 👍🏼