RetroShare / RSNewWebUI

30 stars 20 forks source link

Mail section: Compose Mail, Reply, Reply All, Forward. #80

Closed zelfroster closed 1 year ago

zelfroster commented 1 year ago

Fixed Compose Mail -

Removed config appearance, but kept UI fixes from that PR. Cc and Bcc input remaining in compose mail.

defnax commented 1 year ago

nice composer looks now more clean :)

zelfroster commented 1 year ago

https://github.com/RetroShare/RSNewWebUI/assets/93514460/097f8174-1098-4db2-93a8-302558525be0

I wanted to make it like gmail, where cc and bcc are not shown by default and show when clicked, but will do it later. 1688456578_Jul04_13:12:58

I will work on reply feature first.

defnax commented 1 year ago

one thing is needed too, attach files in composer

zelfroster commented 1 year ago

one thing is needed too, attach files in composer

Alright, I will try to implement it as well.

defnax commented 1 year ago

ok and picture attachments too into the text field

zelfroster commented 1 year ago

ok and picture attachments too into the text field

I looked into it. This will be hard to implement, as It would need to be done differently than the composer already is. Will do it later.

zelfroster commented 1 year ago

I am ashamed to say that I want to hold this for some time and work on the other features for now. I am working on Files Section now.

In files section, there was something which was causing webui to crash, I have found the issue and working on fixing that. As well as, I am trying to implement a feature to view chunks in download progress bar.

csoler commented 1 year ago

It's perfectly fine to step away from one particular job for a while in order to let the ideas mature. Don't worry: when you come back to it, you'll probably fix it.

defnax commented 1 year ago

simplescreenrecorder-2023-07-04_13.04.02.mp4 I wanted to make it like gmail, where cc and bcc are not shown by default and show when clicked, but will do it later. 1688456578_Jul04_13:12:58

I will work on reply feature first.

Hi, but the composer needs to close after send automaticly , you closed manualy the composer, that right?

zelfroster commented 1 year ago

simplescreenrecorder-2023-07-04_13.04.02.mp4 I wanted to make it like gmail, where cc and bcc are not shown by default and show when clicked, but will do it later. 1688456578_Jul04_13:12:58 I will work on reply feature first.

Hi, but the composer needs to close after send automaticly , you closed manualy the composer, that right?

Can be done 👍🏼

zelfroster commented 1 year ago

Reply Mail Finally working, along with some fixes.

Here is a preview of Mail Reply.

https://github.com/RetroShare/RSNewWebUI/assets/93514460/250210d8-b5f8-474e-a8f0-3402306163e6

Also, I had a query about How actual mail content is parsed or composed in Qt side? And, Need suggestions on correctly formatting the reply message conversation.

defnax commented 1 year ago

look here maybe useful for reply header/ quoted message: MessageComposer *MessageComposer::replyMsg(const std::string &msgId, bool all)

https://github.com/RetroShare/RetroShare/blob/7a3c9f7efe06a119c02d64cb7b2e5404d1700755/retroshare-gui/src/gui/msgs/MessageComposer.cpp#L1095

defnax commented 1 year ago

and we has color highlighter on qt for mail replies https://github.com/RetroShare/RetroShare/commit/e4929456128a11e497fe4614092099149aba2b1f

and quoted text with ">" ">>" ... https://github.com/RetroShare/RetroShare/blob/7a3c9f7efe06a119c02d64cb7b2e5404d1700755/retroshare-gui/src/util/HandleRichText.cpp#L1248

image

zelfroster commented 1 year ago

Sorry, I was busy buying PC components and assembling them. @csoler This PR can be reviewed.

zelfroster commented 1 year ago

I also wanted to discuss caching in webui for large set of data, I have so far researched and found out two methods which include using browser's sessionStorage or indexedDb api.

Since same data is fetched multiple times, we can store them for every session so that there are less number of requests for same data.

rottencandy commented 1 year ago

Caching sounds good! You could also look into localStorage API for more persistence.