RetroShare / RSNewWebUI

30 stars 20 forks source link

Share manager for managing shared directories with different permissions #84

Closed zelfroster closed 12 months ago

zelfroster commented 1 year ago

Wrote initial code for Share Manager, Made a SCSS mixin for showing information according to type (concern level). 1692208990_Aug16_23:33:10 1692208970_Aug16_23:32:50 1692208945_Aug16_23:32:25

zelfroster commented 1 year ago

Shared Directories currently looks like this, image

I have used the table layout and the cells are input elements, So, initially inputs are disabled And, when you click Edit button, then inputs are enabled, so it looks like this image

But I am thinking about How to approach the last column (Visibility), Should I create another popup for it like in the Qt app? @rottencandy 1692593993_Aug21_10:29:53

zelfroster commented 1 year ago

Share Manager is complete and It works.

This PR is now ready for review @csoler.

zelfroster commented 1 year ago

Added Icons for share-flags instead of plain checkbox.

zelfroster commented 1 year ago

Hey @csoler, If you need anything else to be done in this PR, please let me know. If not, then this is ready for review.

csoler commented 1 year ago

It really looks good. I just found a few bugs:

All these should be easy to fix!

zelfroster commented 1 year ago

Ohh alright, Thanks for pointing these out. I will fix these.

zelfroster commented 1 year ago

Hello @csoler, I didn't knew there were other groups as well, I previously had simply copied the RsNodeGroupId from rspeers.h 190 in libretroshare.

Now, I have implemented that as well. User defined groups (Test in the below example) now appear in the Share Manager. 1693795731_Sep04_08:18:51

zelfroster commented 1 year ago

I have fixed all the bugs you listed. I hope there's none left. One more thing, there are no events for the actions in Share Manager, so Webui can't be updated if something is changed in Qt App.

zelfroster commented 1 year ago

Now share manager will respond to rs events and update accordingly.

https://github.com/RetroShare/RSNewWebUI/assets/93514460/d1d87a4c-9fa9-4b3b-a97e-f3c0f7273c79