Closed zelfroster closed 12 months ago
Shared Directories currently looks like this,
I have used the table layout and the cells are input elements, So, initially inputs are disabled And, when you click Edit button, then inputs are enabled, so it looks like this
But I am thinking about How to approach the last column (Visibility), Should I create another popup for it like in the Qt app? @rottencandy
Share Manager is complete and It works.
Edit
button on the bottom of the popup, They can edit the entries.
This PR is now ready for review @csoler.
Added Icons for share-flags instead of plain checkbox.
Hey @csoler, If you need anything else to be done in this PR, please let me know. If not, then this is ready for review.
It really looks good. I just found a few bugs:
All these should be easy to fix!
Ohh alright, Thanks for pointing these out. I will fix these.
Hello @csoler, I didn't knew there were other groups as well, I previously had simply copied the RsNodeGroupId from rspeers.h 190 in libretroshare.
Now, I have implemented that as well. User defined groups (Test in the below example) now appear in the Share Manager.
I have fixed all the bugs you listed. I hope there's none left. One more thing, there are no events for the actions in Share Manager, so Webui can't be updated if something is changed in Qt App.
Now share manager will respond to rs events and update accordingly.
https://github.com/RetroShare/RSNewWebUI/assets/93514460/d1d87a4c-9fa9-4b3b-a97e-f3c0f7273c79
Wrote initial code for Share Manager, Made a SCSS mixin for showing information according to type (concern level).
![1692208945_Aug16_23:32:25](https://github.com/RetroShare/RSNewWebUI/assets/93514460/68586237-6186-4d09-b3ab-1dc3c2006c59)