RetroShare / retroshare-mobile

Retroshare mobile phone client
23 stars 8 forks source link

added short invite && Parse short invite feature #17

Closed Kumaravinash9 closed 3 years ago

Kumaravinash9 commented 3 years ago

Fix : #6 Fix : #8

QR Scanner Screen Add Friend Screen About Screen
Create Identity Screen Change Identity Screen Update Identity Screen
Identity Info Screen Emoji Support I Emoji Support II
Kumaravinash9 commented 3 years ago

please merge this PR @csoler

Kumaravinash9 commented 3 years ago

Preview:

Added Feature :

defnax commented 3 years ago

where is the short invite place or field?

Kumaravinash9 commented 3 years ago

where is the short invite place or field?

This QR Code contains the short invite data whenever a person scan this QR he/she will automatically get the short invite. I am still working on UI of Add friend there i will also provide the option by which user can get short invite and long invite link.

Kumaravinash9 commented 3 years ago

Hii @csoler, I have added the changes createAccountV2 in the branch : https://github.com/Kumaravinash9/retroshare-mobile/tree/test But i didnot update the retroshare services ,it's working or not but most probably it should work. Please check it once

csoler commented 3 years ago

could you make a pull request to retroshare-mobile plz? It's easier for testing. I wont merge it. thx!

Kumaravinash9 commented 3 years ago

could you make a pull request to retroshare-mobile plz? It's easier for testing. I wont merge it. thx! done.

Kumaravinash9 commented 3 years ago

Preview Link : https://drive.google.com/file/d/1d2bKhm_TKmE_7V3zQPR2_AgFu1stXRdd/view?usp=sharing @csoler @defnax

Kumaravinash9 commented 3 years ago

@csoler Please merge this PR.

defnax commented 3 years ago

Preview Link : https://drive.google.com/file/d/1d2bKhm_TKmE_7V3zQPR2_AgFu1stXRdd/view?usp=sharing @csoler @defnax

looks nice thx

csoler commented 3 years ago

Is there a way to indicate that this short/long invite choice is for the sake of backward compatibility? I mean, the long invite is only for people who need to connect to computers running a retroshare version < 0.6.6. Users of your application will only need short invite since they all run the 0.6.6 core. So my suggestion is that you put some text next to the button "Retroshare 0.6.5 format" and always default to short invite.

Kumaravinash9 commented 3 years ago

@csoler Added info text and make default to short invite

csoler commented 3 years ago

Great! When you have the opportunity, the text should be 0.6.6 instead of 0.6. I'll merge it anyway. Just make that change when you want.