Refactor codes and Renamed some variable names

RetroShare / retroshare-mobile

Retroshare mobile phone client

23 stars 8 forks source link

Refactor codes and Renamed some variable names #39

Closed Kumaravinash9 closed 3 years ago

defnax commented 3 years ago

can you make a new mobile apk please for testing? lets see if the create profile issue is gone

obrasero commented 3 years ago

This code lost its compilability. The " @Kumaravinash9 Renamed some variable names "-Checkin missed to rename all needed. Added a PR into your Repo which fixes it,.

obrasero commented 3 years ago

lets see if the create profile issue is gone

Profiles with this code are still not creatable on my phone. Also the phenomenology has changed. I reported this already anywhere.

Kumaravinash9 commented 3 years ago

This code lost its compilability. The " @Kumaravinash9 Renamed some variable names "-Checkin missed to rename all needed. Added a PR into your Repo which fixes it,.

Actually i did that changes on my local device but forget to push. Thanks

Kumaravinash9 commented 3 years ago

Image issue has solved

defnax commented 3 years ago

But on rs qt desktop distant chat i can send normaly higher quality picture but now on rs mobile very short one.

when you click on the picture need a fullview option (like how in Telegram/Whatsapp)

picture limitation is only for chat rooms, distant chat picture attachment needs to be optimized allow higher dimensions

Kumaravinash9 commented 3 years ago

Group chat issue has solved now

Kumaravinash9 commented 3 years ago

@csoler can you please merge this PR.