search

Return-To-The-Roots / s25client

Return To The Roots (Settlers II(R) Clone)
http://www.rttr.info
GNU General Public License v2.0
476 stars 75 forks source link

Plugin fixes #1532

Closed tehKaiN closed 1 year ago

tehKaiN commented 2 years ago

Fixes #1521

obraz

Also brings back Military Aid to its full functionality (note the icon which indicates that enemy guardhouse can be attacked):

obraz

Submodule which needs to be merged prior to this one so that I can update submodule refs: https://github.com/Return-To-The-Roots/languages/pull/20

tehKaiN commented 2 years ago

I've made attack indicators optional, for ppl who may dislike them. Added relevant translations

obraz

obraz

This cannot be built by CI because it depends on translations submodule changes, which haven't yet been merged.

tehKaiN commented 2 years ago

Thanks for feedback! I'll rewrite my git history tomorrow so that commit messages are more uniform with your guidelines.

tehKaiN commented 2 years ago

I've moved LOADER thingy inside if as you requested. Perhaps I should do additional work by moving that call into constructor and storing result in the field as I mentioned earlier?

Flamefire commented 2 years ago

Perhaps I should do additional work by moving that call into constructor and storing result in the field as I mentioned earlier?

Yes that might make sense. But then we might want to do that for every texture used which can be an own PR as it will likely be large

Flamefire commented 2 years ago

Seems there was an extra space in the suggestion. Sorry for that, could you fix that? Rest looks good

tehKaiN commented 2 years ago

fixed!

tehKaiN commented 1 year ago

so, can we merge this, or is there something else which I have to fix? :)

Flamefire commented 1 year ago

Yes, all good. the CI failure is unrelated to this PR.