Add support for image cropping inside ctrlImageButton

Return-To-The-Roots / s25client

Return To The Roots (Settlers II(R) Clone)

http://www.rttr.info

GNU General Public License v2.0

476 stars 75 forks source link

Open tehKaiN opened 1 year ago

tehKaiN commented 1 year ago

all things fixed. I'll add unit tests across following days.

Flamefire commented 1 year ago

Thanks, looks good! If you need help with the tests feel free to ask.

tehKaiN commented 1 year ago

I've added some tests as well as corrected inverseLerp to not be templated. Let me know it this suffices, or if you want some more elaborate testing.

tehKaiN commented 1 year ago

oops, I've got some comments to the code in "pending" status and they were not there for you to see.

I'll try to resolve stuff you've mentioned by tomorrow.