Return-To-The-Roots / s25client

Return To The Roots (Settlers II(R) Clone)
http://www.rttr.info
GNU General Public License v2.0
476 stars 75 forks source link

Refactor options screen #1554

Closed Flamefire closed 1 year ago

Flamefire commented 1 year ago

Extracted from #1553

I needed some more space and a way to ease adding a new option.

New: 2023-02-14_19-02-31

Spikeone commented 1 year ago

It'd be great to have an interface option (left of zurück) where some interface options are (like showgameframe info) :)

Flow86 commented 1 year ago

perhaps we should even split out a "Network" category? and put the network stuff there?

Flamefire commented 1 year ago

Makes sense. Maybe open an issue for that so someone with the time for it can do that :) Would be an easy task for first-time contributors I guess.

Flamefire commented 1 year ago

@Flow86 Can this be merged? Required for #1553

Flamefire commented 1 year ago

@Flow86 The required check "Linux (clang, macos-12, Debug)" needs to be changed to "Linux (clang, macos-12, Debug, 1.82.0)"

And what is the issue on Jenkins? Can't login right now to check.

falbrechtskirchinger commented 1 year ago

1594 and #1602 are also waiting on this.

Flow86 commented 1 year ago

Oh I thought this one was already merged.