Return-To-The-Roots / s25client

Return To The Roots (Settlers II(R) Clone)
http://www.rttr.info
GNU General Public License v2.0
476 stars 75 forks source link

some localization is missing #1568

Closed stefson closed 1 year ago

stefson commented 1 year ago

hey, I just noticed a few missing localizations in current git master.

the screen of Receiving mapdata is in english

the options for Military aid are in english only

Economy mode is in english only

Spikeone commented 1 year ago

Wrong project, please report language issues here: https://github.com/Return-To-The-Roots/languages

everybody is welcome to contribute to them :)

EDIT: or is it not possible to translate them? If so that's a bug, if not, contribution from users is missing

stefson commented 1 year ago

well, for the non existing german localization of Receiving map there is an entry in the rttr-de.po, it should state Prüfe Karte instead of displaying the english.

Flamefire commented 1 year ago

Translations are done by the community at https://translations.launchpad.net/s25rttr and eventually imported at https://github.com/Return-To-The-Roots/languages

Spikeone commented 1 year ago

@Flamefire well he is right, the text is not translated in german although there is a german text, thats why I didn't close this issue but guessed that this is either a missing import or a bug of some sort

stefson commented 1 year ago

Just a quick heads up, I won't be around anymore with coming 2FA by tomorrow. Thanks for all the fish! 🐟

Flamefire commented 1 year ago

It seems this is fixed now. Tested with a fresh compile and current nightly. @Spikeone can you confirm?

Spikeone commented 1 year ago

@Flamefire can confirm that "Prüfe Karte..." is shown correctly - those missing entries, well are still missing

Flamefire commented 1 year ago

Ok, then it is not an issue with this repo. There are simply some strings not translated yet in https://github.com/Return-To-The-Roots/languages As there are likely many such strings over all the languages we have I don't think it is worth keeping an issue for single strings in a single language.