search

Return-To-The-Roots / s25client

Return To The Roots (Settlers II(R) Clone)
http://www.rttr.info
GNU General Public License v2.0
477 stars 75 forks source link

Boats row ashore if there is a warehouse #1622

Closed senneschall closed 1 year ago

senneschall commented 1 year ago

A moving picture is worth a thousand words: landrowing btw: the flag on the ship's mast has an offset

Found in: Return To The Roots v20230814 on Ubuntu 22.04 64bit; SDL2-version, OpenGL 4.6 graphics card

Spikeone commented 1 year ago

I think this has been discussed quite some time ago. Either it was just as it was in the original.

Or, if I remember correctly, the worker left the boat in the original, then walked to the storehouse and magically got a new boat. Which doesn't make more sense at all.

Do you mind checking the original?

senneschall commented 1 year ago

I didn't find an issue, that's why I opened a new one, sorry if it's a duplicate.

I just checked with my original v1.51 on dosbox and found that it's actually the same as in rttr: settlersorg

I had in fact expected exactly what you described: that he leaves the boat and walks on land. Do you plan to stay true to the original in cases like this? If so, feel free to close this ticket.

Spikeone commented 1 year ago

Interesting - thanks for checking the original.

Well, depends on, it might be nice to have an animation where a carrier leaves the boat (and the boat stays there), comes back and then hops back into it. So this could be a wish issue (which could be a client side setting since it doesn't alter gameplay). So it depends on you this time, feel free to rename and rephrase it or close it :)

EDIT: And sorry, I didn't mean there was an issue for that, I just remembered that this has been discussed some time ago - somewhere, maybe it was launchpad, maybe IRC, maybe it never happened^^

senneschall commented 1 year ago

Maybe the discussion back then then was with me. Before I checked the original I could have sworn it was like this :)

I'll leave this issue open for others to join in or maybe for a documentation purpose.

Flamefire commented 1 year ago

Well, depends on, it might be nice to have an animation where a carrier leaves the boat (and the boat stays there), comes back and then hops back into it. So this could be a wish issue (which could be a client side setting since it doesn't alter gameplay).

That would actually be a bit hard to implement ;-) Not sure if it is worth the effort as I'd see this as a kind of easteregg/reference to the original :shrug: