search

Return-To-The-Roots / s25client

Return To The Roots (Settlers II(R) Clone)
http://www.rttr.info
GNU General Public License v2.0
470 stars 75 forks source link

fix AI interaction with granite mines with enabled Inexhaustible gran… #1651

Closed desofity closed 3 months ago

desofity commented 4 months ago

Hello!

Currently if addon "Inexhaustible granite mines" is enabled, AI place granite mine on any available mine place. (Because method "SimpleFindPosition" is used instead of "FindBestPosition") Then after building of mine is complete, AI reailizes that there is no resource available and demolishes granite mine.

The code comment says that "inexhaustible granite mines do not require granite" but i can't find any code line that proves that. If that was originally intended to allow building granite mine on any mine place if addon is enabled, we need to add some code in resource map generator, probably. But I decided that this was not intended and just removed condition.

Spikeone commented 4 months ago

well @Flow86 and @desofity - the AI currently correclty implements the addon - since thats how I implemented the addon once (just place graninte mines anywhere). At some point @Flamefire 'fixed' it since the description wasn't clear and it sounded like it is a minimal version of the inexhaustible mines addon. But yeah, the fix is probably fine for now, I need to add my settlers IV mining addons which also solves that addon issue :D