search

Return-To-The-Roots / s25client

Return To The Roots (Settlers II(R) Clone)
http://www.rttr.info
GNU General Public License v2.0
470 stars 75 forks source link

VirusTotal detected virus #1654

Closed mrtnrocks closed 3 months ago

mrtnrocks commented 3 months ago

Hello,

I downloaded Version 20240312 windows x86_64

VirusTotal flagged the file s25rttr_20230814/libvorbis-0.dll as Virus.Win64.Dupshirk

Is this a problem?

Thank you

Flamefire commented 3 months ago

@Flow86 Can you check which version of the DLL gets bundled by Jenkins and where that comes from? It is not https://github.com/Return-To-The-Roots/dev-tools/blob/ab8e8aadc6d79599325a584b95d1132eafe5fc88/msvc/bin/x64/libvorbis-0.dll (check the checksums)

FTR: The 0.9.5 stable release used a different DLL. But the flagged one is used as far back as I can check the available downloads of nightlies.

@mrtnrocks I don't think it is an issue but you can try using the DLL from the above link. It might not work with the official builds though as they are built differently (using MinGW, not MSVC) But maybe that is already the issue: MinGW flagged just because it is "unusual"
You could also try using the DLL from the 0.9.5 release with the current nightly. But again I assume this is simply a false positive by one to eager scanner

mrtnrocks commented 3 months ago

Thank you for helping, but I think I will go with the stable release 😉

Flow86 commented 3 months ago

the libvorbis and all other SDL_mixer dependencies come directly from the SDL_mixer package - And yes, thats a false positive