Closed Flamefire closed 1 month ago
Well, some people would like to use RttR on some old WinXP machines - but we are already missing some dlls on those systems I think so at this time, I'd say it's okay to drop it. But we should update the supported systems (if we havent).
@Flow86 This is basically blocking all other PRs: It is failing CI so I can't accept & merge any PR or get mine into a state that you can merge it (you need to approve mine so in the end you need to merge them)
why not simply removing it from the appveyor? there are still people around using the 32bit variant though.
why not simply removing it from the appveyor? there are still people around using the 32bit variant though.
If we remove it (i.e. don't test it anymore), how can we be sure it works? Yes, there is Jenkins but the logs aren't readily available. Do you have any logs if people really do use/download the 32bit variant? Sounds odd in 2024 and I think it is mostly just by confusion which one works so people might continue using 32bit RttR out of habbit not of need.
I checked the update downloads: In the last 30 days:
so still 3% of windows users using the nightly build use 32bit, its not much, but still we need to perhaps at least first mention "hey we will remove the support", not directly doing it.
Let's disable appveyor first. (btw github does support windows runners in the mean time too, perhaps we should get rid of appveyor all together and migrate to github ci directly?)
so still 3% of windows users using the nightly build use 32bit, its not much, but still we need to perhaps at least first mention "hey we will remove the support", not directly doing it.
Can we make the 32-Bit version a bit less obvious to download - because I agree, that most people may not understand what they are actually downloading and are just happy, that it works fine. That way we may see a more significant drop in downloads. Sadly that would mean waiting some more time.
Ok I found an alternative: just remove the static curl which wasn't used until recently: https://github.com/Return-To-The-Roots/s25client/pull/1667
It is unlikely anyone is still required to use that in 2024
And as it is now too much trouble to maintain (32bit builds on Appveyor started to fail) just drop it, at least officially. It might still work but we don't test it anymore.
See https://github.com/Return-To-The-Roots/s25client/pull/1663 where I tried to fix the 32bit appveyor build which has been failing for a long time now. I guess we could rebuild or remove the static MSVC libcurl library (CMake started to choose it over the shared one "recently") but I'd say it's not worth the time