Reserve window visuals / bugs

Return-To-The-Roots / s25client

Return To The Roots (Settlers II(R) Clone)

http://www.rttr.info

GNU General Public License v2.0

478 stars 77 forks source link

Reserve window visuals / bugs #539

Closed Spikeone closed 8 years ago

Spikeone commented 8 years ago

As I was testing something for the farmer bug, I noticed some "bugs" in the reserve window.

[ ] Buttons not greyed out in the lower section
+/- Buttons have wrong textures (I think it's okay to keep the - red)
[ ] Wrong alignement as you can see, in rttr it's way up
Wrong +/- icons
[ ] Reserve not set to 1 by default for every rank

reserve

Flamefire commented 8 years ago

I would keep the textures but made the rest checkboxes so they will be done. I think our textures are better, design-wise (red/green, bigger marks not just text) and we have some freedom in redesigning dialogs. The default reserve is critical imo

MarcusSt commented 8 years ago

I'd agree to that. We should keep our design as a feature, but adopt the default reserve. @Spikeone: Can you check if there's a default reserve for harbour buildings as well?

Spikeone commented 8 years ago

I quite dislike the overuse of the green texture for buttons. That one is nearly everywhere in RttR and often wrong. But I'd still like the grey texture for those buttons instead of the green version - just as most buttons in s2 were.

Flamefire commented 8 years ago

There was no indicator for disabled buttons ATM. I implemented something by making the textures darker. Making them greyscale with OGL is not that easy so I think that effect must suffice.