Update sysvar.asm - Githubissues

ReturnInfinity / BareMetal-OS-legacy

BareMetal is a 64-bit OS for x86-64 based computers. The OS is written entirely in Assembly while applications can be written in Assembly, C/C++, and Rust.

1.74k stars 303 forks source link

Update sysvar.asm #88

Closed ghost closed 9 years ago

ghost commented 9 years ago

o'rly? :)

AaronM04 commented 9 years ago

Wait, this still doesn't make sense. Based on the "equ" statements, there are only 4096 bytes for each of those two tables. Nice try :)

ghost commented 9 years ago

Yes, but this was painful "0x070000 -> 0x071FFF" == 4096 Bytes ;)

AaronM04 commented 9 years ago

How about changing it to 0x070000 -> 0x070FFF ? Then the comments can be internally consistent and correct, lol

ghost commented 9 years ago

I'm not familiar with AHCI, so i didn't know which was correct (just mentioned it)

AaronM04 commented 9 years ago

Ah good point, I shouldn't have assumed the code was correct :)