ReturnInfinity / BareMetal-OS-legacy

BareMetal is a 64-bit OS for x86-64 based computers. The OS is written entirely in Assembly while applications can be written in Assembly, C/C++, and Rust.
1.74k stars 303 forks source link

add newline after input in os_input #93

Closed Roxxik closed 9 years ago

Roxxik commented 9 years ago

print the newline after it was detected, this mirrors the behaviour i'd expect from a shell more closely

ohnx commented 9 years ago

doesn't the newline print anyways because you hit ENTER?

Roxxik commented 9 years ago

os_input is currently not calling os_print_newline

ohnx commented 9 years ago

interesting... Whenever I run commands in the console/shell, a newline is printed...

Roxxik commented 9 years ago

thats because the cli is calling os_print_newline itself explicitly

call os_input
call os_print_newline       ; The user hit enter so print a new line