search

Revadike / epicgames-freebies-claimer

Claim available free game promotions from the Epic Games Store.
MIT License
2.23k stars 361 forks source link

optional pushbullet notifications #131

Closed ffuubarbuzz closed 2 years ago

Revadike commented 2 years ago

Awesome addition, thanks!

ffuubarbuzz commented 2 years ago

@Revadike Happy to help :) Is docker container published automatically or it needs to be done manually? If latter, could you please do it?

Revadike commented 2 years ago

@jackblk

jackblk commented 2 years ago

@ffuubarbuzz I maintain the docker image so I will push an update tomorrow.

jackblk commented 2 years ago

@ffuubarbuzz @Revadike I pushed the new version to Dockerhub & GithubPackage. Enjoy :).

jackblk commented 2 years ago

@ffuubarbuzz you might want to take a look at #143

In the next version, you will need to change your config to use apprise instead of normal pushbullet config

ffuubarbuzz commented 2 years ago

@jackblk thanks for the heads up! Would be nice to have option name mentioned in the README.md if the docker tag makes it as the latest

jackblk commented 2 years ago

@ffuubarbuzz i'm not sure if i should maintain 2 different images or not, because apprise will increase the docker image a bit. Best case is that I will only maintain 1 image, so you don't need to use different tag.

I will let you know when I have time to test the new docker image.

ffuubarbuzz commented 2 years ago

I personally won't use apprise tag (unless it becomes latest at some point), my concern is just that it's undocumented how to use it.

Revadike commented 2 years ago

undocumented

You mean that there is no wiki page here about it? Or something else?

ffuubarbuzz commented 2 years ago

I mean that option appriseUrl is only mentioned in the PR #143 , so whoever tries to use it will have hard times

jackblk commented 2 years ago

Yeah true, I will update the wiki when I have time, it's not very hard config I think.

For now, you can follow this url config from apprise: https://github.com/caronc/apprise#popular-notification-services

Revadike commented 2 years ago

I mean that option appriseUrl is only mentioned in the PR #143 , so whoever tries to use it will have hard times

It is also in the default config.json