search

Revadike / epicgames-freebies-claimer

Claim available free game promotions from the Epic Games Store.
MIT License
2.23k stars 361 forks source link

refactor: support apprise in main image #157

Closed jackblk closed 2 years ago

jackblk commented 2 years ago

I decide to support Apprise in the main Docker image now, only 20MB more to download, and people only download it once in a while so it doesn't really make sense to support a different tag. Wiki guide will be too long and confusing if we split them into 2 images too.

V1.5.6 image is already up, but after this PR I will update the image and update wiki for Apprise

Revadike commented 2 years ago

Does the docker script support some kind of choice during install, maybe? That may be a better solution, if possible.

jackblk commented 2 years ago

Yeah it does. Currently you can choose between the tag latest (does not have apprise) and latest-apprise.

I'm writing the wiki, it is very long and I think it's confusing for new user trying to use this docker image (with or without apprise). Too much hassle to read and config properly. So if we merge both of them into only one tag latest, there will be less issue/problem in the future.

The drawback is that, the image's size will increase by 20MB. But I think it's acceptable because we only pull the image once in a while.

Revadike commented 2 years ago

Merged