Revadike / epicgames-freebies-claimer

Claim available free game promotions from the Epic Games Store.
MIT License
2.23k stars 361 forks source link

[DOCS] Add minimum Node version (`v15.0.0`) in the README #204

Closed LukeSavefrogs closed 1 year ago

LukeSavefrogs commented 1 year ago

Problem

When running node epic games I get the following error:

→ D:\Progetti\free-games-claimer [main ≡]› node epic-games
file:///D:/Progetti/free-games-claimer/epic-games.js:20
db.data ||= {};
        ^^^

SyntaxError: Unexpected token '||='
    at Loader.moduleStrategy (internal/modules/esm/translators.js:145:18)
    at async link (internal/modules/esm/module_job.js:63:21)

This is because, as stated by the docs the ||= operator is supported from NodeJS >= 15.0.0. After a quick check, it appears on my system i have not this requirement:

→ D:\Progetti\free-games-claimer [main ≡]› node --version
v14.17.1

Solution

Add a disclaimer in the README or in the wiki that you MUST install Node >= 15.

akssshh commented 1 year ago

Hey @LukeSavefrogs Can you assign this to me

LukeSavefrogs commented 1 year ago

Hey @LukeSavefrogs Can you assign this to me

I don't have the permission.

akssshh commented 1 year ago

Screenshot 2022-11-21 at 1 46 06 PM

@LukeSavefrogs @Revadike Is it okay??

LukeSavefrogs commented 1 year ago

Screenshot 2022-11-21 at 1 46 06 PM

@LukeSavefrogs @Revadike Is it okay??

Thank you 😄

akssshh commented 1 year ago

Okay then I'll make PR