search

Revadike / node-epicgames-client-login-adapter

Helper for epicgames-client library, to easy login.
MIT License
1 stars 4 forks source link

Update ID of login button #4

Closed terrabitz closed 3 years ago

terrabitz commented 3 years ago

The Problem

When using the related Epic Freebies Claimer package, I got the following error when attempting to login:

 2021-01-05 | 10:32:55.898 | ERROR | TimeoutError: waiting for selector "#login:not(:disabled)" failed: timeout 30000ms exceeded
    at new WaitTask (/home/terrabitz/Software/epicgames-freebies-claimer/node_modules/puppeteer/lib/DOMWorld.js:549:28)
    at DOMWorld._waitForSelectorOrXPath (/home/terrabitz/Software/epicgames-freebies-claimer/node_modules/puppeteer/lib/DOMWorld.js:478:22)
    at DOMWorld.waitForSelector (/home/terrabitz/Software/epicgames-freebies-claimer/node_modules/puppeteer/lib/DOMWorld.js:432:17)
    at Frame.waitForSelector (/home/terrabitz/Software/epicgames-freebies-claimer/node_modules/puppeteer/lib/FrameManager.js:627:47)
    at Frame.<anonymous> (/home/terrabitz/Software/epicgames-freebies-claimer/node_modules/puppeteer/lib/helper.js:112:23)
    at Page.waitForSelector (/home/terrabitz/Software/epicgames-freebies-claimer/node_modules/puppeteer/lib/Page.js:1122:29)
    at Function.authenticate (/home/terrabitz/Software/epicgames-freebies-claimer/node_modules/epicgames-client-login-adapter/index.js:119:38)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at async Function.init (/home/terrabitz/Software/epicgames-freebies-claimer/node_modules/epicgames-client-login-adapter/index.js:204:7)
    at async /home/terrabitz/Software/epicgames-freebies-claimer/claimer.js:110:28 {
  name: 'TimeoutError'

After some research, I discovered that the ID for the login button was not #login, but rather #sign-in: image

The Solution

This PR simply updates the ID to the new version

Related Issues

https://github.com/Revadike/epicgames-freebies-claimer/issues/66 https://github.com/Revadike/epicgames-freebies-claimer/issues/75

https://github.com/Revadike/node-epicgames-client-login-adapter/pull/3

CrafterKolyan commented 3 years ago

+1 to this

Revadike commented 3 years ago

Sorry for the long wait