Revali25
commented
3 months ago Thanks for the feedback! I am new at using Git, so I was treating it more like a save function than version control, hence the more disorganized commit history. I was paranoid of losing changes so this ended up meaning that things happened out of order. It's good to learn, so I'll keep that in mind going forward.
I won't lie the step by step guide was kind of confusing for me at points, like I'm not really sure what the function of clean specifically is, besides a nebulous "it cleans up the code." I was also having issues with the python version, it wasn't stated in the step by step guide to use version 3.8-3.11, I was able to figure that part out though. Is there a recommended workflow or like, tips and tricks to efficiently find out the proper semantic inflection tags? Not every tag that I needed to use was in the manual of style, the example that comes to mind is <i> being untagged for ships, which I thought the manual said didn't need an inflection.
I don't know why Kate insists on putting files in the working directory instead of a separate cache location, but any file with "kate" in the name in it is from that, and I always tried to make sure it was removed before a commit; that didn't happen all the time evidently though.
I ran clean and lint before making the final commits, but not throughout the process. I'll keep that in mind going forward as well.
When I get home I'll take a look through the issues and address them.
lukasbystricky
Hi Ben,
It looks quite good overall, but there are a few things that need some fixing. I had a couple questions about your workflow though. Why did you add the chapters at different points? It would have made more sense to add them all together after splitting them. It looks like after you add them you'd already run clean, did you run anything else on them before adding them?
In general it would be better if your commit messages were more descriptive. For example a18e30b is "Update chapter 10". It looks like you've run clean and changed some semantics, so a better commit message would be "Clean chapter 10, correct semantics". Likewise in 81d3fd3 the message "Formatted text for chapter 9", but the commit is adding chapters 8 and 9, as well as some CSS. You should also consider keeping commits to a single "type" of work. This isn't always easy to do retroactively so it's not essential, but sometimes it is straightforward. For instance b8227d4 "Updated section-id + added some chapter 10 text" should really be two separate commits (and "added some chapter 10 text" is quite vague so that should be re-worded).
Anyways, I've made a first pass. Let me know if there's anything that's not clear or that you need help with. If you're not quite comfortable with Git it might be a bit daunting, but I don't think it's anything too extreme. Feel free to ask here or in the group chat if you have any questions.
<i>around ship names. You should use se:name.vessel.shipspantag. I think you should tag "Bugle Song" as a song instead of a poem.