RevealBi / Reveal.Sdk

Issue tracker - Reveal SDK https://www.revealbi.io/
https://www.revealbi.io/
3 stars 0 forks source link

Add the ability to hide the database brand icon (Postgresql Elephant, etc.) #175

Open ItWorksOnMyMachine opened 6 months ago

ItWorksOnMyMachine commented 6 months ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. This isn't a problem other than the database brand icon is meaningless to our customers. The technology behind our app is transparent to our users and the Postgresql Elephant showing up doesn't match out brand and could be confusing to our customers.

Describe the solution you'd like Add the ability to hide or change the database brand icon wherever data source information is displayed.

Describe alternatives you've considered N/A

Additional context Add any other context or screenshots about the feature request here.

image
jberes commented 6 months ago

From aue on Discord suggestion on how to do this as a hackaround:

Example with CSS modules using React:

:global(#dataSource_Ds_Name) { canvas { display: none; } :global(#dataSource_overflow_icon_Ds_Name) { display: initial; } }

@brianlagunas this comes up a lot -

@ItWorksOnMyMachine this is a bit extreme, but you can completely change this dialog to your own:

https://github.com/RevealBi/sdk-samples-javascript/blob/main/CustomDataSourceSelectionDialog/index.html

ItWorksOnMyMachine commented 6 months ago

Thanks @jberes, that works for the dialog, however these icons show up in other areas, like the visualization editor, etc.

image

exscalliber commented 6 months ago

I'm Auē from the discord chat, id also love to see this feature being built.

As mentioned above i have a bit of a hack for it but its prone to breaking.