RevenueCat / cordova-plugin-purchases

Cordova in-app purchases and subscriptions made easy.
https://www.revenuecat.com/
MIT License
58 stars 13 forks source link

Matching version of purchases hybrid with Capacitor for migration #562

Closed 0xymoro closed 3 months ago

0xymoro commented 3 months ago

Hi, we use RC for a Nextjs Capacitor app. The app pulls from deployed live web from a Vercel deployment, and we're migrating from this Cordova plugin to the Capacitor one.

We're upgrading to 8.0.0 for the Capacitor app now, and during the migration we're trying to build our apps to have both Capacitor and Cordova packages in the native so it can call either of them (to have maximum compatibility during app reviews and not have downtime).

I'm getting this due to this package not having the latest in purchases hybrid:

[!] CocoaPods could not find compatible versions for pod "PurchasesHybridCommon": In Podfile: CordovaPluginsStatic (from ../capacitor-cordova-ios-plugins) was resolved to 6.1.1, which depends on PurchasesHybridCommon (= 10.9.0)

RevenuecatPurchasesCapacitor (from `../../node_modules/@revenuecat/purchases-capacitor`) was resolved to 8.0.0, which depends on
  PurchasesHybridCommon (= 11.1.1)

This should be a pretty simple fix to bump the versions. Thanks!

RCGitBot commented 3 months ago

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

Jethro87 commented 3 months ago

Hi @0xymoro, thanks for reporting this. Cordova is deprecated (as per our docs here) and we don't plan to support new major versions. However, I have shared this with my engineering team regarding bumping PurchasesHybridCommon. I'll keep you posted if we're able to do this.

One thing to note is having two versions of our SDK running simultaneously could possibly lead to issues - if by chance you configure both, for example, you'll have 2 different versions of an SDK running at the same time using the same underlying data storage, which could cause unexpected issues.

Jethro87 commented 3 months ago

@0xymoro #568 has been opened, which will add support for the main changes in the latest majors in Cordova. Notably, this doesn't support some of the latest features like installment plans and pending prepaid plans in Android, but it will support Billing Client 7 and StoreKit2.

I'm going to close this for now, but please feel free to re-open it if you have additional questions. Thanks!