Closed tonidero closed 2 months ago
Attention: Patch coverage is 74.28571%
with 9 lines
in your changes are missing coverage. Please review.
Project coverage is 83.31%. Comparing base (
22d7098
) to head (46257e5
).:exclamation: Current head 46257e5 differs from pull request most recent head dd0ce31. Consider uploading reports for the commit dd0ce31 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
1 Message | |
---|---|
:book: | Size increase: 4.03 KB |
Generated by :no_entry_sign: Danger
Description
We were clearing the diagnostics file during SDK configuration if we detected the file to be too big. We could make this clearing happen during tracking of events. Advantages of this:
This shouldn't be a problem performance-wise since we are doing all this in a background thread + checking the file size is pretty quick.