search

RevenueCat / purchases-android

Android in-app purchases and subscriptions made easy.
https://www.revenuecat.com/
MIT License
235 stars 45 forks source link

Do not consume IAPs when backend returns 4xx errors #1699

Closed tonidero closed 2 months ago

tonidero commented 2 months ago

Description

As part of the efforts to support non-consumables in android, we talked about not consuming IAPs when the backend returns a 4xx error. This should be an uncommon case but we don't want to miss the data in that case.

This depends on the changes to support non-consumables in #1697

RevenueCat-Danger-Bot commented 2 months ago
1 Message
:book: Size increase: 0.13 KB

Generated by :no_entry_sign: Danger

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 83.12%. Comparing base (7a4dbdc) to head (ff8be45).

:exclamation: Current head ff8be45 differs from pull request most recent head 24be329

Please upload reports for the commit 24be329 to get more accurate results.

Files Patch % Lines
...tlin/com/revenuecat/purchases/PostReceiptHelper.kt 75.00% 0 Missing and 4 partials :warning:
...purchases/common/networking/PostReceiptResponse.kt 69.23% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1699 +/- ## ========================================== + Coverage 83.07% 83.12% +0.05% ========================================== Files 222 222 Lines 7581 7574 -7 Branches 1073 1070 -3 ========================================== - Hits 6298 6296 -2 + Misses 857 854 -3 + Partials 426 424 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.