RevenueCat / purchases-android

Android in-app purchases and subscriptions made easy.
https://www.revenuecat.com/
MIT License
235 stars 45 forks source link

Remove internal ObserverMode mentions #1710

Closed JayShortway closed 1 month ago

JayShortway commented 1 month ago

This removes all internal mentions of the term "observer mode", except when still necessary to test deprecated APIs.

RevenueCat-Danger-Bot commented 1 month ago
1 Message
:book: Size increase: 2.16 KB

Generated by :no_entry_sign: Danger

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.17%. Comparing base (b8bae4a) to head (f3ef682).

Files Patch % Lines
...n/com/revenuecat/purchases/amazon/AmazonBilling.kt 38.46% 5 Missing and 3 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1710 +/- ## ======================================= Coverage 83.16% 83.17% ======================================= Files 223 223 Lines 7593 7596 +3 Branches 1074 1075 +1 ======================================= + Hits 6315 6318 +3 Misses 854 854 Partials 424 424 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JayShortway commented 1 month ago

How deep do we want to go with PurchasesAreCompletedBy? In my opinion, at some point components just need to know the relevant interpretation of it, without knowing all enum cases. For most components, that means knowing whether to finish transactions or not.

In practice this means I added PurchasesAreCompletedBy to the AppConfig constructor, but not to anything "below" that.

What are your thoughts?

JayShortway commented 1 month ago

We could opt to rename finishTransactions to something like completePurchases or finishPurchases to

but I don't feel strongly either way.

Thoughts?