Closed JayShortway closed 1 month ago
1 Message | |
---|---|
:book: | Size increase: 2.16 KB |
Generated by :no_entry_sign: Danger
Attention: Patch coverage is 65.21739%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 83.17%. Comparing base (
b8bae4a
) to head (f3ef682
).
Files | Patch % | Lines |
---|---|---|
...n/com/revenuecat/purchases/amazon/AmazonBilling.kt | 38.46% | 5 Missing and 3 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
How deep do we want to go with PurchasesAreCompletedBy
? In my opinion, at some point components just need to know the relevant interpretation of it, without knowing all enum cases. For most components, that means knowing whether to finish transactions or not.
In practice this means I added PurchasesAreCompletedBy
to the AppConfig
constructor, but not to anything "below" that.
What are your thoughts?
We could opt to rename finishTransactions
to something like completePurchases
or finishPurchases
to
PurchasesAreCompletedBy
, but I don't feel strongly either way.
Thoughts?
This removes all internal mentions of the term "observer mode", except when still necessary to test deprecated APIs.
PurchasesAreCompletedBy
enum.finishTransactions
boolean, as that is the relevant interpretation ofPurchasesAreCompletedBy
for most components.