RevenueCat / purchases-android

Android in-app purchases and subscriptions made easy.
https://www.revenuecat.com/
MIT License
235 stars 45 forks source link

Fix purchase tester offerings not reloading #1715

Closed tonidero closed 1 month ago

tonidero commented 1 month ago

Description

I've run into some issues with purchase tester for a while where the offerings were not updated after changing screens or purchasing. This simplifies the reloading so it loads always. There might be more performant options, but considering this is a test app, I didn't want to dedicate too much time to it.

RevenueCat-Danger-Bot commented 1 month ago
1 Message
:book: Size increase: 0.00 KB

Generated by :no_entry_sign: Danger

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.14%. Comparing base (740e694) to head (ca6bca4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1715 +/- ## ======================================= Coverage 83.14% 83.14% ======================================= Files 222 222 Lines 7582 7582 Branches 1072 1072 ======================================= Hits 6304 6304 Misses 854 854 Partials 424 424 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tonidero commented 1 month ago

I was also thinking that if this were a Compose app, it would be a lot easier to do quick changes to it, as Compose generally requires less code to write. But yea, migrating to Compose is a big change haha.

Yup definitely, I think moving to Compose would be great but we can tackle that when we have time