Closed joshdholtz closed 3 days ago
Attention: Patch coverage is 6.97674%
with 40 lines
in your changes missing coverage. Please review.
Project coverage is 82.88%. Comparing base (
76724cf
) to head (95d7a34
). Report is 23 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...n/com/revenuecat/purchases/paywalls/PaywallData.kt | 6.97% | 40 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
One other thing, should the package selector be anchored to the bottom of the screen, together with the purchase button? Seems to me it would look nicer than tied to the main content.
I was going to mention the same as @tonidero . I also don't think Google will like that the selected package details is behind the button, like the subscribe button is visible but it's possible the price is covered, like in this screenshot
I was going to mention the same as @tonidero . I also don't think Google will like that the selected package details is behind the button, like the subscribe button is visible but it's possible the price is covered, like in this screenshot
Yeaaaahhh, this makes sense! I'll talk to the team about this tomorrow to see what we want to do about it 🤔 Thanks for bringing this up!
1 Warning | |
---|---|
:warning: | This PR increases the size of the repo by more than 100.00 KB (increased by 103.03 KB). |
Generated by :no_entry_sign: Danger
Motivation
Template 5 but with multiple tiers 😊
Supports...
Description
PackageConfigurationType
forMULTITIER
PaywallTemplate
forTEMPLATE_7
PaywallData
with...localizationByTier
PaywallData.Configuration
with...packages
defaults to `emptyList()imagesByTier: Map<String, ColorInformation>?
colorsByTier: Map<String, Images>?
tiers: List<Tier>?
PaywallData.Configuration.ColorInfomation
with...tierControlBackground: PaywallColor?
tierControlForeground: PaywallColor?
tierControlSelectedBackground: PaywallColor?
tierControlSelectedForeground: PaywallColor?
Demo
Screenshots
Video (with animations)
https://github.com/RevenueCat/purchases-android/assets/401294/b06d0dd5-3449-44d9-ad6f-9894bc0edc61