RevenueCat / purchases-android

Android in-app purchases and subscriptions made easy.
https://www.revenuecat.com/
MIT License
235 stars 45 forks source link

Added new paywall template to support multiple tiered subscriptions #1720

Closed joshdholtz closed 3 days ago

joshdholtz commented 1 month ago

Motivation

Template 5 but with multiple tiers 😊

Supports...

Description

Demo

Screenshots

Portrait Landscape Footer Footer Condensed
Screenshot 2024-06-17 at 10 41 36 AM Screenshot 2024-06-17 at 10 36 19 AM Screenshot 2024-06-17 at 10 40 29 AM Screenshot 2024-06-17 at 10 40 33 AM

Video (with animations)

https://github.com/RevenueCat/purchases-android/assets/401294/b06d0dd5-3449-44d9-ad6f-9894bc0edc61

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 6.97674% with 40 lines in your changes missing coverage. Please review.

Project coverage is 82.88%. Comparing base (76724cf) to head (95d7a34). Report is 23 commits behind head on main.

Files Patch % Lines
...n/com/revenuecat/purchases/paywalls/PaywallData.kt 6.97% 40 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1720 +/- ## ========================================== - Coverage 83.32% 82.88% -0.45% ========================================== Files 222 222 Lines 7550 7589 +39 Branches 1060 1066 +6 ========================================== - Hits 6291 6290 -1 - Misses 845 885 +40 Partials 414 414 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tonidero commented 1 month ago

One other thing, should the package selector be anchored to the bottom of the screen, together with the purchase button? Seems to me it would look nicer than tied to the main content.

vegaro commented 1 month ago

I was going to mention the same as @tonidero . I also don't think Google will like that the selected package details is behind the button, like the subscribe button is visible but it's possible the price is covered, like in this screenshot

CleanShot 2024-06-19 at 12 22 17@2x

joshdholtz commented 1 month ago

I was going to mention the same as @tonidero . I also don't think Google will like that the selected package details is behind the button, like the subscribe button is visible but it's possible the price is covered, like in this screenshot

CleanShot 2024-06-19 at 12 22 17@2x

Yeaaaahhh, this makes sense! I'll talk to the team about this tomorrow to see what we want to do about it 🤔 Thanks for bringing this up!

RevenueCat-Danger-Bot commented 2 weeks ago
1 Warning
:warning: This PR increases the size of the repo by more than 100.00 KB (increased by 103.03 KB).

Generated by :no_entry_sign: Danger