Fixes crash if no browser is installed

JayShortway commented 1 month ago

Changes

Main

Adds UriHandler.openUriOrElse(), inspired by the stdlib's Map.getOrElse().
Uses openUriOrElse() in the Footer to log a warning if there's no browser installed.
Tests
Adds FooterLinksNoBrowserTest.

Closes #1723

RevenueCat-Danger-Bot commented 1 month ago

	1 Message
:book:	Size increase: 4.76 KB

Generated by :no_entry_sign: Danger

JayShortway commented 1 month ago

Do you think this PR should close https://github.com/RevenueCat/purchases-android/issues/1723? Or should we wait for the toast?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.17%. Comparing base (5b8935b) to head (1d56a41). Report is 3 commits behind head on main.

:exclamation: Current head 1d56a41 differs from pull request most recent head 193d32d

Please upload reports for the commit 193d32d to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1727 +/- ## ======================================= Coverage 83.17% 83.17% ======================================= Files 223 223 Lines 7596 7596 Branches 1075 1075 ======================================= Hits 6318 6318 Misses 854 854 Partials 424 424 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vegaro commented 1 month ago

Also, I think we can close that issue, since this actually fixes it.

What would the toast show? Some standalone terms and conditions?

RevenueCat / purchases-android