RevenueCat / purchases-ios

In-app purchases and subscriptions made easy. Support for iOS, watchOS, tvOS, macOS, and visionOS.
https://www.revenuecat.com/
MIT License
2.26k stars 303 forks source link

Add NSPrivacyAccessedAPICategoryFileTimestamp to privacy report #3874

Closed vegaro closed 3 months ago

vegaro commented 3 months ago

As reported in https://github.com/RevenueCat/purchases-flutter/issues/1064 we were missing an entry

Added C617.1 as reason which reads:

Declare this reason to access the timestamps, size, or other metadata of files inside the app container, app group container, or the app’s CloudKit container.

https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api#4278393

RevenueCat-Danger-Bot commented 3 months ago
1 Message
:book: Size increase: 0.21 KB

Generated by :no_entry_sign: Danger

tonidero commented 3 months ago

Hmm interesting... From what I see, it seems that it's detecting we need that permission because of the AppleReceipt and AppleReceiptBuilder containing the string creationDate, even though that does not come from a file... I think we don't really need this permission right now IMO, but maybe someone else can correct me if I'm wrong? Not sure how to disable that warning though, so maybe this is the easiest way...

vegaro commented 3 months ago

I see what you mean. Maybe we don't need to add it yes.. I believe we do need the phc one though

aboedo commented 3 months ago

+1, I believe that's a false positive from the detection script, but we do need the privacy manifest for PHC

vegaro commented 3 months ago

Closing this for now