Cleanup: Remove test storekit configuration files when importing through SPM.

RevenueCat / purchases-ios

In-app purchases and subscriptions made easy. Support for iOS, watchOS, tvOS, macOS, and visionOS.

https://www.revenuecat.com/

MIT License

2.26k stars 303 forks source link

Closed aboedo closed 3 months ago

aboedo commented 3 months ago

This PR removes the storekit configuration files we use for testing when you import the SDK through SPM.

This cleans up apps, since those files were somewhat "leaked" from our tests, but not meant for consumption by a customer.

Before	After

This PR does two things:

Removes all test targets from SPM. We don't really use SPM for testing directly, so they didn't really add value there.
Adds a new Package.swift file at the root of the Tests folder, which in turn tells SPM to treat that folder as a separate package, and thus the files in there don't get picked up automatically when importing RevenueCat.

RevenueCat-Danger-Bot commented 3 months ago

	1 Message
:book:	Size increase: 0.61 KB

Generated by :no_entry_sign: Danger

aboedo commented 3 months ago

apparently we did run tests from SPM for UI tests, but I'm not sure why yet, I'll take a look. Feels odd to have only one suite run from SPM.

aboedo commented 3 months ago

started looking into fixing the SPM test, and I fell into quite the rabbit hole:

the tests are set up to use the SPM package
RevenueCatUI is set up solely as an SPM package
Making it an Xcode target instead (with a corresponding test target) fixes that
... but then when doing that, I get a lot of warnings and issues for sendable and ABI stability. Not sure why we're not getting those when compiling as an SPM package, whether that's that those aren't checked with SPM or that there's a config setting in Xcode that looks different

aboedo commented 3 months ago

I'm gonna try a simpler approach with only the package.swift file, we'll see how that goes

aboedo commented 3 months ago

closing in favor of #3878