[EXTERNAL] Hide decorative Paywall images from accessibility (#3886) via @shiftingsand

[tonidero]

Description

Added .accessibilityHidden(true) to the two images in RemoteImage. I initially was hesitant to change RemoteImage itself, but went ahead and did so since it seems to be only used by the Paywall templates.

Contributed by @shiftingsand in #3886

[RevenueCat-Danger-Bot]

	1 Message
:book:	Size increase: 0.10 KB

Generated by :no_entry_sign: Danger

[tonidero]

Yeah, I agree the ideal is to allow adding this information in the dashboard so it can be set dynamically in the same origin as the image itself. However, we might take a bit longer to support this. I think this is a better compromise than what we have right now in the meantime.

I don't fully like the approach of adding the label as a parameter in the code, since it would mean:

• It can't be set dynamically from the same origin as the backend
• We will need to deprecate it once we actually support setting it from the dashboard.
• We don't expose the RemoteImage itself as an API. We would need to expose this option at the PaywallView level and pass it around, which seems pretty disconnected...

cc @aboedo for a third opinion!

[tonidero]

As talked, we are going with this for now, and we can add support for backend driven labels later.