search

RevenueCat / purchases-ios

In-app purchases and subscriptions made easy. Support for iOS, watchOS, tvOS, macOS, and visionOS.
https://www.revenuecat.com/
MIT License
2.2k stars 295 forks source link

Add SwiftLint as a build tool plugin for the Swift Package project #3928

Closed vegaro closed 2 weeks ago

vegaro commented 1 month ago

Following instructions in https://github.com/realm/SwiftLint#swift-package-build-tool-plugins

We had Swiftlint enabled for the Xcode project, but not for the Swift Package project. The Xcode project doesn't have RevenueCatUI code, so there was no way to get swiftlint errors in xcode for RevenueCatUI files.

RevenueCat-Danger-Bot commented 1 month ago
1 Message
:book: Size increase: 2.77 KB

Generated by :no_entry_sign: Danger

vegaro commented 1 month ago

I think the problem with this approach is that it will bring it for our consumers 🤔 @jamesrb1

vegaro commented 2 weeks ago

going to close this for now, because I think the reorg of the project makes more sense