search

RevenueCat / purchases-ios

In-app purchases and subscriptions made easy. Support for iOS, watchOS, tvOS, macOS, and visionOS.
https://www.revenuecat.com/
MIT License
2.32k stars 314 forks source link

Should the func onChangeOf<V> be private? #3943

Closed alpennec closed 3 months ago

alpennec commented 3 months ago

Hey,

I've noticed Xcode autocompletion suggests me the function onChangeOf from your SDK instead of the SwiftUI onChange by default.

Should this function be private?

Thanks!

image image
RCGitBot commented 3 months ago

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

HaleyRevcat commented 3 months ago

Hi, you can use SwiftUI's onChange function if you want to use a private version of this. Our engineers are looking into making our function not public, please see Josh's reply.

alpennec commented 3 months ago

Why is your method public?

joshdholtz commented 3 months ago

@alpennec Hey! Always good to see a friendly face 😊 This has already been fixed in #3788 which is going out in our new major which should be soon™️

This was accidentally made public and we would prefer to not introduce a breaking change (even though making internal is the correct behavior) in a non-major. So this should not longer be public within weeks once v5 is released 💪

alpennec commented 3 months ago

Thanks @joshdholtz, thanks for letting me know! Happy to see this is soon fixed.

github-actions[bot] commented 3 months ago

This issue has been automatically locked due to no recent activity after it was closed. Please open a new issue for related reports.