RevenueCat / purchases-kmp

RevenueCat SDK for Kotlin Multiplatform
MIT License
70 stars 2 forks source link

Adopt Latest PHC Version #139

Closed fire-at-will closed 3 weeks ago

fire-at-will commented 1 month ago

This PR updates the KMP SDK to consume the latest changes in PHC 13.0.1. Once it is merged, we should be ready for a beta 3 release.

Description

Specifically, this PR:

fire-at-will commented 3 weeks ago

@tonidero About SubscriptionOption.installmentInfo - it looks like the Android SubscriptionInfo object is actually a typealias for the Android com.revenuecat.purchases.models.SubscriptionOption, which already has installmentInfo added to it 😄

Screenshot 2024-08-19 at 8 52 25 AM Screenshot 2024-08-19 at 8 52 37 AM
JayShortway commented 3 weeks ago

@tonidero @fire-at-will Yea that's true, but this means it's only usable in the Android source set. I think it's beneficial if we can access it from the common source set, so for that we'd need to add a public API in commonMain/[...]/SubscriptionOption.kt. However, we can also do that when we converting away from typealiases (but we should make sure not to forget).

fire-at-will commented 3 weeks ago

@JayShortway I'll give it a shot! Will be back in a few minutes! :D

fire-at-will commented 3 weeks ago

@JayShortway @tonidero The changes to add InstallmentInfos started to be spread across several files, so I opened a PR into this branch to make it easier to review: https://github.com/RevenueCat/purchases-kmp/pull/150