RevenueCat / purchases-kmp

RevenueCat SDK for Kotlin Multiplatform
MIT License
70 stars 2 forks source link

Refactor expect/actual from more enums to avoid typealiases #140

Closed tonidero closed 1 month ago

tonidero commented 1 month ago

Description

This continues the work in #137

In this one, we are removing them from the enums:

Additionally, there are a couple extra changes that were made as part of this PR. Note that some of these are breaking... But feels it should be ok for now.

JayShortway commented 1 month ago

@tonidero I set the base branch of this PR to the integration branch, and merged the integration branch in. I know you prefer rebase, but I didn't want to end up having to force push to someone else's branch. Hope you don't mind! 🙏

tonidero commented 1 month ago

Thanks for handling that @JayShortway! I believe I addressed most comments. Do you think there is anything else that we should do in this PR?

JayShortway commented 1 month ago

@tonidero @vegaro Integration branch is rebased onto main, and this PR is up to date with that. After we squash and merge this, history should be clean again. 😄 (I made a note of the number of files and lines changed before all the force-pushes, and it's the same now.)

@tonidero I think this PR is good to go!

tonidero commented 1 month ago

Hmm seems tests are not passing with the recent merge commits 🤔

tonidero commented 1 month ago

Ohh ok, tests seem to only run on PRs pointing to main... I think it might be ok to merge this then, since tests were passing before.