Closed tonidero closed 1 month ago
@tonidero I set the base branch of this PR to the integration branch, and merged the integration branch in. I know you prefer rebase, but I didn't want to end up having to force push to someone else's branch. Hope you don't mind! 🙏
Thanks for handling that @JayShortway! I believe I addressed most comments. Do you think there is anything else that we should do in this PR?
@tonidero @vegaro Integration branch is rebased onto main
, and this PR is up to date with that. After we squash and merge this, history should be clean again. 😄 (I made a note of the number of files and lines changed before all the force-pushes, and it's the same now.)
@tonidero I think this PR is good to go!
Hmm seems tests are not passing with the recent merge commits 🤔
Ohh ok, tests seem to only run on PRs pointing to main
... I think it might be ok to merge this then, since tests were passing before.
Description
This continues the work in #137
In this one, we are removing them from the enums:
Additionally, there are a couple extra changes that were made as part of this PR. Note that some of these are breaking... But feels it should be ok for now.
ReplacementMode
in the purchase methods.PricingPhase
to use extensions to avoid having to rewrite the whole offering response classes in this PR. I expect we will want to revert this change in future PRs, but did this in order to keep it clean for now.