RevenueCat / purchases-kmp

RevenueCat SDK for Kotlin Multiplatform
MIT License
70 stars 2 forks source link

Temporarily reverts "Remove expect/actual from enums without extra properties (#137)" #141

Closed JayShortway closed 1 month ago

JayShortway commented 1 month ago

What

This reverts commit 1fb4e8d738ef6fbbd1c27115d22c74ba66d552df and, with that, PR #137.

Why

This is only temporary. The reverted PR has left main in a broken state, as some properties are shadowed but their types have changed. (See https://github.com/RevenueCat/purchases-kmp/pull/140#discussion_r1711533087 for a similar problem and explanation.) We don't want main in a broken state, as we're about to release beta.3.

See also this thread for some more context: https://github.com/RevenueCat/purchases-kmp/pull/140#discussion_r1711261313.