Do not expose phc api - Githubissues

RevenueCat / purchases-kmp

RevenueCat SDK for Kotlin Multiplatform

MIT License

70 stars 2 forks source link

Closed tonidero closed 2 weeks ago

tonidero commented 2 weeks ago

[ ] If applicable, unit tests
[ ] If applicable, create follow-up issues for purchases-android, purchases-ios and other hybrids

This Integration branch has the changes in order to be able to hide the PHC API

RevenueCat-Danger-Bot commented 2 weeks ago

	1 Warning
:warning:	This PR increases the size of the repo by more than 100.00 KB (increased by 198.20 KB).

Generated by :no_entry_sign: Danger

JayShortway commented 2 weeks ago

@tonidero @vegaro I think this can be merged, right? What do you think, squashing or not?

The intermediate commits are "broken", but it's a giant commit otherwise. Would be a wall you run into every time you check the git history. 😅

tonidero commented 2 weeks ago

I would say normal merge, not squashing. But then, fix the CHANGELOG, so it only shows as one item. Putting it up for review!