RevenueCat / purchases-kmp

RevenueCat SDK for Kotlin Multiplatform
MIT License
70 stars 2 forks source link

Language management - iOS paywall #173

Closed lopspower closed 1 week ago

lopspower commented 1 week ago

Describe the bug I'm developing two applications with Kotlin multiplatform. Everything is well configured, I can see the paywall and I can subscribe on both platforms. However, on iOS, when I run the test on a French device, I see the English paywall (I don't have this problem on Android, I can see the French and English paywall depending on the language of my device.). I've checked, my App Store is in French and my phone is in French too. The paywall is still displayed in English, even though it is configured in French on your platform. What's more, when I click to subscribe, the native Apple view is displayed in French. Which confirms what I said above. I don't think the problem lies with the native SDK, but probably with this KMP library. Isn't there a configuration missing for language management on iOS?

  1. Environment
    1. Platform: iOS
    2. SDK version: 1.0.0-beta.3 & 1.0.0-beta.2
    3. OS version: iOS 17.6.1
    4. IDE (e.g. Android Studio, Xcode, Fleet): Xcode
    5. IDE version: Xcode
    6. Device and/or emulator/simulator:
      • [X] Device
      • [X] Emulator/simulator
    7. Environment:
      • [X] Closed testing / Sandbox
      • [X] TestFlight
      • [X] Production
    8. How widespread is the issue. Percentage of devices affected.
  2. Debug logs that reproduce the issue
  3. Steps to reproduce, with a description of expected vs. actual behavior
  4. Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)

Additional context I've contacted support with all the screenshots. I can't share the same screenshots here for privacy reasons.

JayShortway commented 1 week ago

Hi, thanks for reporting this! I can indeed reproduce this issue using 1.0.0-beta.3.

There were some recent fixes to our purchases-ios SDK, which the purchases-kmp SDK transitively depends on. Those fixes seem to do the trick, as it fails to reproduce using the current head of main for me. That means this should be fixed in the upcoming 1.0.0 stable release of purchases-kmp. Should be any day now.

Let me know if you have any other questions!

JayShortway commented 1 week ago

The stable release was just published. Let me know if it's indeed fixed when you have time to update!

lopspower commented 1 week ago

I can confirm that it does fix the problem, thanks for your responsiveness.

JayShortway commented 1 week ago

Thanks for confirming, great to hear!