Closed awstanley closed 5 years ago
Additional note that storage::Directory
is scheduled for removal or redesign.
I can't think of a sane reason to build a directory system when std::filesystem
now contains one, but there may be a reason.
The redesign would likely be more for archive/package building, and thus unpacking/extraction should it be needed, though the question becomes whether or not it's worth it.
Adding for consideration: @Brand2 @Legendsmith @metasymphony
Handled by pull request.
As the FileSystem API got hosed during the 2018 API rewrite, it needs to be redesigned.
The various discussions we've had on Discord seem to point to the following considerations:
reversingspace::storage
is the current API support, which is designed to be used by archives (or as the underlying system);%APPDATA%
on older Windows systems, or~/.<product>
on Linux).The issue is two part:
Additional consideration comes from games like Factorio which allow for custom userland directories to be set. I'm not sure if this is a direct point of relevance here.
This library could also use a CMake option to include or exclude preference directory selection (e.g.
%APPDATA%
for Windows 7, whatever the nominal path is on Windows 8/8.1/10). Such a system would likely require iteration over older directories, though given the Windows 10 minimum, and the common path selection in Windows 7/8/8.1 anyway, it's probably best to use the (Microsoft) prescribed standard (whatever that is at the moment).