search

ReversingSpace / cpp-gamefilesystem

Game and general prototyping filesystem support.
Other
1 stars 2 forks source link

FileSystem API #8

Closed awstanley closed 6 years ago

awstanley commented 6 years ago

Actual filesystem API is pushed. While it should be functional, it is untested, and this is just the API (to get it pushed before the weekend so others have some time to look at it).

It adds a gfs namespace below reversingspace containing a heap of artifacts.

There are a few known minor issues in the CMake construction, most significant of which is the lack of Header/Source distinction in Visual Studio (for those who use it as an IDE). That could probably do with being its own issue post-merge of this.

Review request beyond the usual is to look at the API as it pertains to general use. Is there anything missing, is there anything significant in there that's a problem?

Leads to missing API functionality (which I'm personally disinclined to block on), CMake fixes, and test writing.

awstanley commented 6 years ago

Refactored CMakeLists and split tests into its own CMake file to keep things cleaner.

awstanley commented 6 years ago

Test has been added for StorageServer as well as various (invisible) fixes. Missing from the notes is the removal of bad API inlines which were masked by the static-only testing nature.

Additional changes have been made to the system in a few places which are largely syntactic (though nothing pressing enough to put in the changelog).

awstanley commented 6 years ago

Untracked (but committed) bump to complete the test cycle for fetching files from non-userland directories. Since the StorageSystem has no way to pull a dataland file as read/write, this should more or less solve it.

The simulated creation (using a std::ofstream hack) should be good enough here.