ReviewNB / support

Issues and feature requests for ReviewNB
https://reviewnb.com
58 stars 8 forks source link

Render attached images in preview #106

Closed alanhdu closed 2 years ago

alanhdu commented 2 years ago

In Jupyterlab, you can copy-paste images into a Jupyter notebook that get stored as "attachments" (as in the following GIF):

index

In the notebook, this is stored as an additional attachments field in the cell type, like:

{
   "cell_type": ...,
   "attachments": {
       {"db08b428-8cc7-4f27-9495-a9ffab5aa30c.png": {"image/png": "base64 string"}}
   },
}

This is a super convenient way to ensure that images are bundled with the notebook, but it doesn't look these attached images get rendered on ReviewNB right now (in ReviewNB, I only see the image name getting rendered as text rather than the actual image). Would it be possible to ensure that the actual image is rendered as well?

(I could've sworn this used to work, so it might be that I'm doing something wrong now?)

amit1rrr commented 2 years ago

@alanhdu Thank you for reporting this with the detailed information. We've now deployed a fix that renders the attachments properly. Let me know if you face any issues. Thanks again.

Closing. Please feel free to reopen if you see any issues.

alanhdu commented 2 years ago

Thanks! I can confirm that this is fixed on our side!